fix: allow token-based auth #747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we must use an empty username and the token as the password: https://docs.ntfy.sh/publish/#access-tokens
Owner
|
i like the idea, but maybe we should make the token a separate entity? then we could have both, use token if it is set, or fall back to regular login/password authentication if it is not or invalid (i expect token could be revoked while the credentials are still valid). |
Owner
|
Token auth added to the latest rewrite. Please test and see if it works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's probably a better way to do this, but ntfy allows us to use curl's basic auth to authenticate with an access token. This means that sometimes, an empty username is acceptable.