Augment JSON ABI #1429
Draft
Augment JSON ABI #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
bkhouri
force-pushed
the
t/main/augment_event_stream_json
branch
3 times, most recently
from
eb44837 to
46c32f1
Compare
grynspan
reviewed
Dec 2, 2025
Documentation/ABI/JSON.md
Outdated
| <bug> ::= { | ||
| ["url": <string>,] ; the bug url | ||
| ["id": <string>,] ; the bug id | ||
| "title": <string> ; the human readable bug title |
Contributor
There was a problem hiding this comment.
"title" should be optional.
Author
There was a problem hiding this comment.
You're write.. I thought I had seen it as required. My mistake.
BTW, nice catch.
grynspan
reviewed
Dec 2, 2025
Documentation/ABI/JSON.md
Outdated
| <tags> ::= <string> ; a string representation of a tag | ||
| <bug> ::= { | ||
| ["url": <string>,] ; the bug url |
Contributor
There was a problem hiding this comment.
Suggested change
| ["url": <string>,] ; the bug url | |
| ["url": <string>,] ; the bug URL |
(Nitpick)
grynspan
reviewed
Dec 2, 2025
| var bugs: [Bug]? | ||
|
|
||
| /// The time limits associated with the test. | ||
| var timeLimit: Int? |
Contributor
There was a problem hiding this comment.
Suggested change
| var timeLimit: Int? | |
| var timeLimit: Double? |
Subsecond precision is possible, at least nominally.
grynspan
reviewed
Dec 2, 2025
| self.bugs = bugs | ||
| } | ||
| if #available(_clockAPI , *) { | ||
| if let seconds = test.timeLimit?.components.seconds { |
Contributor
There was a problem hiding this comment.
Suggested change
| if let seconds = test.timeLimit?.components.seconds { | |
| self.timeLimit = test.timeLimit | |
| .map(TimeValue.init) | |
| .map(Double.init) |
(Brain-compiled.)
Author
There was a problem hiding this comment.
Hmmm.. that code delta looks wild. Our of curiosity, how does the TimeValue.init know to call the initializer with the value of test.timeLimit?
grynspan
reviewed
Dec 2, 2025
| /// | ||
| /// - Warning: Tags are not yet part of the JSON schema. | ||
| var _tags: [String]? | ||
| var tags: [String]? |
Contributor
There was a problem hiding this comment.
Suggested change
| var tags: [String]? | |
| /// | |
| /// @Metadata { | |
| /// @Available(Swift, introduced: 6.3) | |
| /// } | |
| var tags: [String]? |
grynspan
reviewed
Dec 2, 2025
| var _tags: [String]? | ||
| var tags: [String]? | ||
|
|
||
| // The bugs associated with the test. |
Contributor
There was a problem hiding this comment.
Suggested change
| // The bugs associated with the test. | |
| // The bugs associated with the test. | |
| /// | |
| /// @Metadata { | |
| /// @Available(Swift, introduced: 6.3) | |
| /// } |
grynspan
reviewed
Dec 2, 2025
| // The bugs associated with the test. | ||
| var bugs: [Bug]? | ||
|
|
||
| /// The time limits associated with the test. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// The time limits associated with the test. | |
| /// The time limits associated with the test. | |
| /// | |
| /// @Metadata { | |
| /// @Available(Swift, introduced: 6.3) | |
| /// } |
bkhouri
force-pushed
the
t/main/augment_event_stream_json
branch
2 times, most recently
from
abd2d37 to
95d2763
Compare
Add tags, bug and timeLimit traits to the test ABI JSON data.
bkhouri
force-pushed
the
t/main/augment_event_stream_json
branch
from
95d2763 to
b3bda79
Compare
bkhouri
commented
Dec 11, 2025
| <test-id> ::= <string> ; an opaque string representing the test case | ||
| <tag> ::= "." <string> ; a string representation of a tag |
Author
There was a problem hiding this comment.
chore (blocking): Update to reflect actual behaviour
Contributor
There was a problem hiding this comment.
Drop the "." from the definition please! Even if it's mandated, this wouldn't be syntactically correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO BE COMPLETED.
Add tags, bug and timeLimit traits to the ABI JSON data.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Checklist: