Skip to content

Conversation

@scholzj
Copy link
Member

@scholzj scholzj commented Dec 9, 2025

Type of change

  • Refactoring

Description

This PR refactors thre KafkaConnectBuildTest to make it more in-sync with other Connect and MM2 unit tests. It uses static variables to configure things in a single place, makes sure the Connect resources used in the tests are valid Connect resources, and merges some tests together where it made sense.

Checklist

  • Make sure all tests pass

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.50.0 milestone Dec 9, 2025
@scholzj scholzj requested a review from ppatierno December 9, 2025 16:06
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.79%. Comparing base (fcc675d) to head (8946da6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12219      +/-   ##
============================================
+ Coverage     74.77%   74.79%   +0.01%     
- Complexity     6625     6630       +5     
============================================
  Files           377      377              
  Lines         25360    25360              
  Branches       3402     3402              
============================================
+ Hits          18963    18967       +4     
+ Misses         5008     5007       -1     
+ Partials       1389     1386       -3     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant