Skip to content

Conversation

@Amansingh0807
Copy link
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: na
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • add constants/float16/inv-two-pi

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float16/inv-two-pi $\color{green}45/45$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}45/45$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

'use strict';

/**
* Inverse of twice the mathematical constant `π` (1/(2π)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amansingh0807 Your Api call for the module should be consistent in the documentation as well which is in README.md. Would you mind changing that!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it.


#### FLOAT16_INV_TWO_PI

Inverse of twice the mathematical constant [π][pi].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Inverse of twice the mathematical constant [π][pi].
Inverse of twice the mathematical constant [π][pi] (1/(2π)).


# FLOAT16_INV_TWO_PI

> Inverse of twice the mathematical constant [π][pi].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Inverse of twice the mathematical constant [π][pi].
> Inverse of twice the mathematical constant [π][pi] (1/(2π)).

@Neerajpathak07
Copy link
Member

Also for now we do not have the double and single precision version of inv-two-pi in the code base would you mind adding those as well!!

@Amansingh0807
Copy link
Contributor Author

Also for now we do not have the double and single precision version of inv-two-pi in the code base would you mind adding those as well!!

Doing it as well, Thank you for Pointing out.

@Neerajpathak07 Neerajpathak07 added the Feature Issue or pull request for adding a new feature. label Dec 11, 2025
Add proper @constant JSDoc block with Wikipedia reference.
Remove unnecessary MODULES section.
Ensure consistent API documentation in both lib/index.js and README.md.

Addresses review feedback from @Neerajpathak07
@Amansingh0807
Copy link
Contributor Author

Hi @Neerajpathak07,
Thanks for the review! I have applied the suggested changes, and I’m now working on adding the double-precision and single-precision versions of inv-two-pi as well.
Will open the PRs shortly.

@Neerajpathak07
Copy link
Member

Great!! Looking forward to it XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants