Skip to content

Conversation

@lejmr
Copy link

@lejmr lejmr commented Jun 30, 2019

This pull request adds autodiscovery for linear LVs and captures its performance. Subsequently, graphs are prepared for each LV

@hairmare hairmare requested a review from paraenggu June 30, 2019 21:49
@hairmare hairmare requested review from paraenggu and removed request for paraenggu November 4, 2019 17:53
@hairmare
Copy link
Member

hairmare commented Nov 4, 2019

@paraenggu PTAL

@paraenggu
Copy link
Member

I'm really sorry @lejmr I completely forgot about this PR :-(

Thanks a lot for your contribution. Having access to I/O performance metrics could be really helpful.

However, I think this shouldn't be added to this LVM template, but rather put into a separate generic Linux block stats template. The user parameters can be used for other block devices as well and aren't limited to LVM devices.

The low-level discovery of the block devices could be based on /proc/diskstats or sub-entries of the /sys/class/block/ directory for Zabbix installations which don't have support for built-in low-level discovery of block devices (< 4.4.0).

mty22 pushed a commit to mty22/rabe-zabbix that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants