Skip to content

Conversation

@NickBeginner
Copy link
Contributor

This PR fixes 32936

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 00f29ea to 2bc8557 Compare December 1, 2025 21:31
@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Dec 1, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 1, 2025

/cc @gsmet (hibernate-orm)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you'll need to update docs as well, to mention the new component types in that list:

==== Plugging in other custom components
The Quarkus extension for Hibernate ORM will automatically
inject components annotated with `@PersistenceUnitExtension` into Hibernate Search.
The annotation can optionally target a specific persistence unit with `@PersistenceUnitExtension(name = "nameOfYourPU")`.
This feature is available for the following component types:
`org.hibernate.Interceptor`::
See <<interceptors>>.
`org.hibernate.resource.jdbc.spi.StatementInspector`::
See <<statement_inspectors>>.
`org.hibernate.type.format.FormatMapper`::
See <<json_xml_serialization_deserialization>>.
`io.quarkus.hibernate.orm.runtime.tenant.TenantResolver`::
See <<multitenancy>>.
`io.quarkus.hibernate.orm.runtime.tenant.TenantConnectionResolver`::
See <<programmatically-resolving-tenants-connections>>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yrodiere i added the new components to the list, but i did not create the pages dedicate to them, is it okay or do you want me also to add the pages?

Comment on lines 662 to 656
private void applyMetadataBuilderContributor() {
Object metadataBuilderContributorSetting = buildTimeSettings
.get(JpaSettings.METADATA_BUILDER_CONTRIBUTOR);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to deprecate the metadata build contributor, now that you're introducing an alternative.

A @Deprecated annotation + @deprecated javadoc tag there would do the trick:

Optional<@WithConverter(TrimmedStringConverter.class) String> metadataBuilderContributor();

@NickBeginner NickBeginner changed the title ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor, FunctionContributor and AdditionalMappingContributor ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor and FunctionContributor Dec 4, 2025
@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 20ae00d to 1579e01 Compare December 7, 2025 20:38
@NickBeginner NickBeginner marked this pull request as ready for review December 7, 2025 20:45
@NickBeginner NickBeginner requested a review from yrodiere December 7, 2025 20:45
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

🎊 PR Preview 91dd950 has been successfully built and deployed to https://quarkus-pr-main-51323-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 5d74a21 to d2b28c3 Compare December 8, 2025 10:52
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d2b28c3.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 17 Build Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Initial JDK 17 Build #

- Failing: extensions/hibernate-orm/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/flyway/deployment and 124 more

📦 extensions/hibernate-orm/runtime

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.27.0:validate (default) on project quarkus-hibernate-orm: File '/home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/PersistenceUnitUtil.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/hibernate-orm/runtime net.revelc.code.formatter:formatter-maven-plugin:2.27.0:format`) and commit before running validation!

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 8, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d2b28c3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow plugging in Hibernate ORM's TypeContributor, FunctionContributor and AdditionalMappingContributor

2 participants