-
Notifications
You must be signed in to change notification settings - Fork 3k
ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor and FunctionContributor #51323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
00f29ea to
2bc8557
Compare
|
/cc @gsmet (hibernate-orm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you'll need to update docs as well, to mention the new component types in that list:
quarkus/docs/src/main/asciidoc/hibernate-orm.adoc
Lines 543 to 561 in 206858a
| ==== Plugging in other custom components | |
| The Quarkus extension for Hibernate ORM will automatically | |
| inject components annotated with `@PersistenceUnitExtension` into Hibernate Search. | |
| The annotation can optionally target a specific persistence unit with `@PersistenceUnitExtension(name = "nameOfYourPU")`. | |
| This feature is available for the following component types: | |
| `org.hibernate.Interceptor`:: | |
| See <<interceptors>>. | |
| `org.hibernate.resource.jdbc.spi.StatementInspector`:: | |
| See <<statement_inspectors>>. | |
| `org.hibernate.type.format.FormatMapper`:: | |
| See <<json_xml_serialization_deserialization>>. | |
| `io.quarkus.hibernate.orm.runtime.tenant.TenantResolver`:: | |
| See <<multitenancy>>. | |
| `io.quarkus.hibernate.orm.runtime.tenant.TenantConnectionResolver`:: | |
| See <<programmatically-resolving-tenants-connections>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yrodiere i added the new components to the list, but i did not create the pages dedicate to them, is it okay or do you want me also to add the pages?
...orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/boot/FastBootMetadataBuilder.java
Outdated
Show resolved
Hide resolved
...orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/boot/FastBootMetadataBuilder.java
Outdated
Show resolved
Hide resolved
| private void applyMetadataBuilderContributor() { | ||
| Object metadataBuilderContributorSetting = buildTimeSettings | ||
| .get(JpaSettings.METADATA_BUILDER_CONTRIBUTOR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to deprecate the metadata build contributor, now that you're introducing an alternative.
A @Deprecated annotation + @deprecated javadoc tag there would do the trick:
Line 141 in 02cb12f
| Optional<@WithConverter(TrimmedStringConverter.class) String> metadataBuilderContributor(); |
20ae00d to
1579e01
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview 91dd950 has been successfully built and deployed to https://quarkus-pr-main-51323-preview.surge.sh/version/main/guides/
|
…tributions" This reverts commit 00f29ea.
5d74a21 to
d2b28c3
Compare
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ❌ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ Initial JDK 17 Build #
- Failing: extensions/hibernate-orm/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/flyway/deployment and 124 more📦 extensions/hibernate-orm/runtime
❌ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.27.0:validate (default) on project quarkus-hibernate-orm: File '/home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/PersistenceUnitUtil.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/hibernate-orm/runtime net.revelc.code.formatter:formatter-maven-plugin:2.27.0:format`) and commit before running validation!
Status for workflow
|

This PR fixes 32936