Skip to content

fix Fingerprint fi overflow cause index out of range panic #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martianzhang wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix Fingerprint fi overflow cause index out of range panic #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3831223
fix fi overflow cause index out of range panic
martianzhang Mar 29, 2018
9e53ee8
Merge pull request #1 from percona/master
martianzhang Jul 6, 2018
8ab6e2f
Merge branch 'master' into HEAD
martianzhang Nov 8, 2018
213e365
update test case TestFingerprintWithNumberInDbName
martianzhang Nov 22, 2018
0ec5ea7
Merge branch 'master' into master
rnovikovP Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions query/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@ func Fingerprint(q string) string {
if Debug {
fmt.Printf("\n%d:%d %s/%s [%d:%d] %x %q\n", qi, fi, stateName[s], stateName[sqlState], cpFromOffset, cpToOffset, r, r)
}
// check `fi` overflow
if fi >= len(f) {
break
}

/**
* 1. Skip parts of the query for certain states.
Expand Down
7 changes: 7 additions & 0 deletions query/query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,4 +635,11 @@ func TestFingerprintWithNumberInDbName(t *testing.T) {
"select 123foo from 123foo",
query.Fingerprint(q),
)
// fix fi overflow cause index out of range panic
q = "insert into tb values(1)"
assert.Equal(
t,
"insert into tb values(?+)",
query.Fingerprint(q),
)
}