Fix: initialize undomanager for empty document #7962
Conversation
benjaminfrueh
force-pushed
the
fix/init-undomanager-empty-doc
branch
from
07762fd to
54f60f9
Compare
| }, | ||
| initUndoManagerForEmptyDocument() { | ||
| if ( |
There was a problem hiding this comment.
Is this something that gets added to the history and pushing steps to the server? As discussed I'd be fine with this as a workaround but we should file an upstream issue at least.
There was a problem hiding this comment.
@juliusknorr I clear the history after deleting the space, and in my test there were no steps added to the database in this process. I agree that an upstream issue for yjs should be created and this workaround should be removed once the issue is fixed or a better workaround is found.
There was a problem hiding this comment.
Ok, would be fine with me then.
However tests seem to fail quite heavily. Maybe it has some unexpected side effects?
There was a problem hiding this comment.
Some failing tests, such as the ones counting characters seem to be timing-related and caused by this change. Making the tests even more flaky with this workaround doesn't seem ideal. Maybe we should discuss and explore an alternative less invasive workaround for this.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
juliusknorr
force-pushed
the
fix/init-undomanager-empty-doc
branch
from
54f60f9 to
cff9c03
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
The first paste action in an empty document was not being tracked by the Yjs UndoManager, making it impossible to undo and not tracking it as a change.
This adds initUndoManagerForEmptyDocument() which primes the undo manager by inserting and deleting a space, then clearing the undo stack. This ensures user actions are properly tracked.