enhance: [2.6] support pause GC at collection level (#45943) #46201
+477
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add collection-level granularity to the garbage collector pause/resume mechanism. Previously, GC pause affected all collections globally. Now operators can pause GC for specific collections while allowing other collections to continue normal GC operations. Changes: - Add `pausedCollection` concurrent map to track per-collection pause state - Extend `Pause()` and `Resume()` methods with `collectionID` parameter - Add `collectionGCPaused()` helper to check collection pause status - Skip dropped segment recycling when collection GC is paused - Update management API to accept optional `collection_id` query parameter - Add `GetInt64Value()` utility function for parsing int64 from KV pairs - Maintain backward compatibility: collectionID <= 0 triggers global pause This provides DevOps with finer control over Milvus data lifecycle. issue: milvus-io#45941 --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Contributor
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 2.6 #46201 +/- ##
==========================================
- Coverage 76.99% 76.06% -0.93%
==========================================
Files 1700 1876 +176
Lines 262533 291961 +29428
==========================================
+ Hits 202142 222092 +19950
- Misses 53550 62473 +8923
- Partials 6841 7396 +555
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #45943
Add collection-level granularity to the garbage collector pause/resume mechanism. Previously, GC pause affected all collections globally. Now operators can pause GC for specific collections while allowing other collections to continue normal GC operations.
Changes:
pausedCollectionconcurrent map to track per-collection pause statePause()andResume()methods withcollectionIDparametercollectionGCPaused()helper to check collection pause statuscollection_idquery parameterGetInt64Value()utility function for parsing int64 from KV pairsThis provides DevOps with finer control over Milvus data lifecycle.
issue: #45941