-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: [2.6] Add field data alignment validation to prevent partial update panic #46180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.6] Add field data alignment validation to prevent partial update panic #46180
Conversation
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #46180 +/- ##
==========================================
- Coverage 76.99% 73.56% -3.44%
==========================================
Files 1700 1361 -339
Lines 262533 212001 -50532
==========================================
- Hits 202142 155962 -46180
+ Misses 53550 48618 -4932
- Partials 6841 7421 +580
🚀 New features to boost your workflow:
|
…ate panic issue: milvus-io#46176 pr: milvus-io#46177 - Add checkAligned validation before processing partial update field data to prevent index out of range panic when field data arrays have mismatched lengths - Fix GetNumRowOfFieldDataWithSchema to handle Timestamptz string format and Geometry WKT format properly - Add unit tests for empty data array scenarios in partial update Signed-off-by: Wei Liu <wei.liu@zilliz.com>
7d25ccf to
a7ae96c
Compare
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
|
/ci-rerun-ut |
|
/ci-rerun-ut-go |
liliu-z
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liliu-z, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
|
/set-milestone 2.6.8 |
|
[INFO] Set milestone to: 2.6.8 |
|
/refresh-label |
|
[INFO] PR Label Summary by Refresh-Label
[SUCCESS] PR #46177 merged to master
Use /refresh-label to update related check and label manually |
|
/ci-rerun-e2e-default |
|
/run-cpu-e2e |
issue: #46176
pr: #46177