Skip to content

Conversation

@weiliu1031
Copy link
Contributor

issue: #46176
pr: #46177

  • Add checkAligned validation before processing partial update field data to prevent index out of range panic when field data arrays have mismatched lengths
  • Fix GetNumRowOfFieldDataWithSchema to handle Timestamptz string format and Geometry WKT format properly
  • Add unit tests for empty data array scenarios in partial update

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 8, 2025
@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Dec 8, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #46177 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.56%. Comparing base (cb08db0) to head (a7ae96c).
⚠️ Report is 367 commits behind head on 2.6.

Files with missing lines Patch % Lines
pkg/util/funcutil/func.go 0.00% 6 Missing ⚠️
internal/proxy/task_upsert.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #46180      +/-   ##
==========================================
- Coverage   76.99%   73.56%   -3.44%     
==========================================
  Files        1700     1361     -339     
  Lines      262533   212001   -50532     
==========================================
- Hits       202142   155962   -46180     
+ Misses      53550    48618    -4932     
- Partials     6841     7421     +580     
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) ⬇️
Core ∅ <ø> (∅)
Go 74.24% <51.03%> (-1.15%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/task_upsert.go 55.08% <85.71%> (+2.84%) ⬆️
pkg/util/funcutil/func.go 61.41% <0.00%> (-0.33%) ⬇️

... and 1010 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ate panic

issue: milvus-io#46176
pr: milvus-io#46177

- Add checkAligned validation before processing partial update field
  data to prevent index out of range panic when field data arrays
  have mismatched lengths
- Fix GetNumRowOfFieldDataWithSchema to handle Timestamptz string
  format and Geometry WKT format properly
- Add unit tests for empty data array scenarios in partial update

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the fix_proxy_upsert_panic26 branch from 7d25ccf to a7ae96c Compare December 8, 2025 10:42
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #46177 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@weiliu1031
Copy link
Contributor Author

/ci-rerun-ut

@weiliu1031
Copy link
Contributor Author

/ci-rerun-ut-go

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #46177 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@weiliu1031
Copy link
Contributor Author

/set-milestone 2.6.8

@sre-ci-robot sre-ci-robot added this to the 2.6.8 milestone Dec 9, 2025
@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Dec 9, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] Set milestone to: 2.6.8

@weiliu1031
Copy link
Contributor Author

/refresh-label

@sre-ci-robot sre-ci-robot removed the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Dec 9, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Refresh-Label

  • Title: fix: [2.6] Add field data alignment validation to prevent partial update panic
  • Target: 2.6
  • Labels: kind/bug, size/L, approved, lgtm, dco-passed, do-not-merge/need-merge-master-first

[SUCCESS] PR #46177 merged to master

Use /refresh-label to update related check and label manually

@weiliu1031
Copy link
Contributor Author

/ci-rerun-e2e-default

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 9, 2025
@sre-ci-robot sre-ci-robot merged commit 3d067de into milvus-io:2.6 Dec 9, 2025
13 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants