Skip to content

Conversation

@smdsbz
Copy link
Contributor

@smdsbz smdsbz commented Dec 8, 2025

properly printing result size and limit in error message

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 8, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 8, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2025

@smdsbz Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.28%. Comparing base (1917bb7) to head (5ffad40).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_query.go 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (41.28%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (1917bb7) and HEAD (5ffad40). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (1917bb7) HEAD (5ffad40)
9 2
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #46175       +/-   ##
===========================================
- Coverage   76.00%   41.28%   -34.72%     
===========================================
  Files        1895     1232      -663     
  Lines      296168   195202   -100966     
===========================================
- Hits       225102    80589   -144513     
- Misses      63616   114276    +50660     
+ Partials     7450      337     -7113     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 82.74% <100.00%> (+<0.01%) ⬆️
Go 9.56% <0.00%> (-64.49%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentInterface.cpp 69.66% <100.00%> (ø)
internal/proxy/task_query.go 0.00% <0.00%> (-74.50%) ⬇️

... and 1290 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Dec 8, 2025
Signed-off-by: smdsbz <smdsbz@qq.com>
@smdsbz smdsbz force-pushed the fix-result-size-err branch from ea211f0 to 5ffad40 Compare December 8, 2025 09:26
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smdsbz
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-passed DCO check passed. do-not-merge/missing-related-issue kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants