-
Notifications
You must be signed in to change notification settings - Fork 507
Added --deobfuscate flag to enable string deobfuscation without prompt #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @RajaeDev6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the FLOSS command-line interface by introducing a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a --deobfuscate flag to allow non-interactive enabling of string deobfuscation, which is a great addition for automation. The implementation is sound. My review includes a suggestion to simplify the logic for better readability. Additionally, for completeness, I recommend adding documentation for the new flag in doc/usage.md and a test case to verify its functionality and prevent future regressions.
This PR adds a '--deobfuscate' cli flag, allowing users to enable string deobfuscation without a interactive prompt.
When output is redirected (e.g. floss test.exe > file.txt), FLOSS does not show the y/N prompt, not making deobfuscation possible.
If --deobfuscate flag is set, FLOSS enables decode, tight, and stack strings directly. If its not set and stdout is a TTY, FLOSS falls back to the interactive prompt
Closes #1176