-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Improve discovery flow for Squeezelite #153958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey there @rajlaud, @pssc, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
bump |
Proposed change
When the Squeezebox integration is added, it searches the network for LMS. This PR incorporates the show_progress form whilst the discovery is underway. If nothing is discovered, the flow goes directly to a manual form. If a server is discovered, the flow uses a menu to offer to configure the discovered LMS or a different one. If the discovered LMS is chosen, then flow tests connectivity using default options, and if these allow connection, the config entry is created without needing to display a form.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: