Multi-action grid widget implementation #4783
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @mrdanielps
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
mrdanielps
force-pushed
the
grid-widget
branch
from
8fa697b to
c3eb2e3
Compare
|
Looking great! Will the state of each item reflect in realtime? for example if the light is ON |
Not yet. As mentioned in the additional notes, I limited the scope of this PR for the initial review, just to get some feedback. Although looking at the entity widget implementation, I see it should be pretty straightforward to add, so I'll look into as soon as I can. |
|
How often can a widget update in Android? In iOS the minimum auto-refresh is 15 minutes (besides other techniques like updating through push notification trigger) |
|
It's actually quite similar on Android. The fastest auto-refresh is 30 minutes, but AFAIK anything that wakes up the app can manually trigger an update, like broadcasts or push notifications. Widget interactions can also update it, so pressing the button will allow for the state to be updated immediately. |
|
The template widget updates instantly for me, there is no delay there. Our Template widget and entity state widget use a websocket subscription to update instantly. |
|
@dshokouhi so you keep a websocket connection all the time for the widget? 🪫😭 |
For widgets only when the screen turns on, then we stop the connection when the screen turns off. Its our best effort to keep them as up to as possible while not draining too much battery
yup same for local push we never stop the connection and also send a ping to the server every 30 seconds to ensure its active and current. |
Done! Screen_recording_20241111_005218.webm |
common/build.gradle.kts
Outdated
| implementation(libs.androidx.lifecycle.runtime.ktx) | ||
| implementation(libs.androidx.lifecycle.viewmodel.ktx) | ||
| implementation(libs.androidx.media) | ||
| api(libs.core.remoteviews) |
There was a problem hiding this comment.
does this need to be included in the common module? I dont seem to see it used in any common module files
There was a problem hiding this comment.
You're right, it's only actually needed in :app and :automotive. I've now moved the declaration to each module.
|
Gave this PR a quick test run. I think you have captured the obvious missing features like auto complete, ideally the behavior for each action should mimic the existing button widget with how fields are populated. I think that will match general user expectation. For example that widget handles when a custom integration provides incomplete action data and also when a user provides invalid action data. Looking forward to seeing this PR progress! |
mrdanielps
force-pushed
the
grid-widget
branch
from
7b0edda to
0257657
Compare
I see, I was thinking of implementing it like the entity widget, which only takes an ID, but I'll certainly take that into account. |
|
There is no progress in this? 🫠 It's a really interesting improvement |
|
Wish this could be merged.... |
|
Sorry for the long wait! I hope to have it ready soon enough, but for those interested, here's a sneak peek. glance-grid-widget.mp4 |
Adds a new widget that allows to configure multiple actions. Fixes home-assistant#1193 home-assistant#4549
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <appwidget-provider xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:minWidth="40dp" | ||
| android:minHeight="40dp" | ||
| android:targetCellWidth="4" | ||
| android:targetCellHeight="2" | ||
| android:updatePeriodMillis="86400000" | ||
| android:description="@string/widget_grid_desc" | ||
| android:previewImage="@drawable/widget_example_grid" | ||
| android:initialLayout="@layout/glance_default_loading_layout" | ||
| android:configure="io.homeassistant.companion.android.widgets.grid.config.GridWidgetConfigureActivity" | ||
| android:resizeMode="horizontal|vertical" | ||
| android:widgetCategory="home_screen" | ||
| android:widgetFeatures="reconfigurable" | ||
| tools:ignore="UnusedAttribute"> | ||
| </appwidget-provider> No newline at end of file |
Check failure
Code scanning / Android Lint
Unused resources Error
|
This is awesome! Also like the idea of the reload button to prevent excessive connections to check status. Can't wait! |
5 participants
Summary
Adds a new widget that allows the user to configure multiple actions in a grid. It's somewhat based on the existing ButtonWidget.
The widget is responsive, adjusting the number of columns based on size, and becomes scrollable when it doesn't fit all the actions.
Fixes #1193, #4549
Screenshots
Dynamic colors - light
Dynamic colors - dark
API <31
Configuration and resizing
Screen_recording_20241102_185549.mp4
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1132
Any other notes
I've limited the scope of this PR for easier review, hence the draft status, but I will update it based on feedback.
The main features I think are necessary before merging are auto-completion for icons and action data, feedback when the button is pressed, and maybe entity states.
Additionally, the existing button widget could be updated to reflect the UI changes and share some of their code. However, I didn't want to change too much considering a proposal exists to refactor this code (#4640).