feat: add the ability to complete tasks directly from the widget. #168
Conversation
…d a circular dependency bug with background refresh
kolaente
changed the title
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Outdated
Show resolved
Hide resolved
|
@leschbenedikt @kolaente The above check is failing because now dart is saying that it wants to format 157 files? I dont think we want to touch so many files on this mr. |
|
@brokoli18 it said only one was changed: |
| var title: String, | ||
| var dueDate: Date, | ||
| var today: Boolean, | ||
| var overdue: Boolean, |
There was a problem hiding this comment.
This seems to be unused
There was a problem hiding this comment.
This class is used when the widget pulls tasks from shared storage. I don't need most of the values from the default Task class for the widget so it was easier to create a new one
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Show resolved
Hide resolved
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Composable | ||
| private fun GlanceContent(context: Context, currentState: HomeWidgetGlanceState) { |
There was a problem hiding this comment.
The size and position of the widget changes depending of the number of task.
I think this should always be the same.
| Text("Today:") | ||
| } | ||
| items(todayTasks.sortedBy { it.dueDate }) { task -> | ||
| RenderRow(context, task, prefs, "HH:mm") |
There was a problem hiding this comment.
The pattern shouldn't be hardcoded, the should depend on the locale.
You can just pick some of the predefined ones from flutter
| Text("OverDue") | ||
| } | ||
| items(otherTasks.sortedBy { it.dueDate }) { task -> | ||
| RenderRow(context, task, prefs, "dd MMM HH:mm") |
| Future<void> widgetCallback(Uri? uri) async { | ||
| if (uri?.host == "completetask") { | ||
| String? taskID = uri?.queryParameters['taskID']; | ||
| completeTask(taskID!); |
There was a problem hiding this comment.
If taskID is null just do nothing
Otherwise it will crash
3 participants
Also fixed a circular dependency bug with background refresh.
Resolves #152