JS: Use question-mark variant in all overlay annotations

javascript/ql/lib/Expressions/ExprHasNoEffect.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes and predicates for the 'js/useless-expression' query.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/LanguageFeatures/UnusedIndexVariable.qll

@@ -1,7 +1,7 @@
 /**
  * Provides a predicate for identifying unused index variables in loops.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/AMD.qll

@@ -2,7 +2,7 @@
  * Provides classes for working with
  * [Asynchronous Module Definitions](https://github.com/amdjs/amdjs-api/wiki/AMD).
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/AST.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with the AST-based representation of JavaScript programs.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript
@@ -477,7 +477,7 @@ module AST {
     DataFlow::AnalyzedNode analyze() { result = DataFlow::valueNode(this).analyze() }
 
     /** Gets the data flow node associated with this program element. */
-    overlay[caller]
+    overlay[caller?]
     pragma[inline]
     DataFlow::ValueNode flow() { result = DataFlow::valueNode(this) }
 

javascript/ql/lib/semmle/javascript/CFG.qll

@@ -272,7 +272,7 @@
  * Note that the `import` statement as a whole is part of the CFG of the body, while its single
  * import specifier `x as y` forms part of the preamble.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Classes.qll

@@ -4,7 +4,7 @@
  * Class declarations and class expressions are modeled by (QL) classes `ClassDeclaration`
  * and `ClassExpression`, respectively, which are both subclasses of `ClassDefinition`.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Closure.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with the Closure-Library module system.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Comments.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with JavaScript comments. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Constants.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with expressions that evaluate to constant values.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/DefUse.qll

@@ -1,5 +1,5 @@
 /** Provides classes and predicates for working with variable definitions and uses. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/E4X.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with E4X.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/ES2015Modules.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with ECMAScript 2015 modules. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Errors.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with syntax errors. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Expr.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with expressions.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript
@@ -253,7 +253,7 @@ class Expr extends @expr, ExprOrStmt, ExprOrType, AST::ValueNode {
    * Gets the data-flow node where exceptions thrown by this expression will
    * propagate if this expression causes an exception to be thrown.
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::Node getExceptionTarget() {
     result = getCatchParameterFromStmt(getRawEnclosingStmt(this))
@@ -271,7 +271,7 @@ private DataFlow::Node getCatchParameterFromStmt(Stmt stmt) {
     DataFlow::parameterNode(stmt.getEnclosingTryCatchStmt().getACatchClause().getAParameter())
 }
 
-overlay[caller]
+overlay[caller?]
 pragma[inline]
 private Stmt getRawEnclosingStmt(Expr e) {
   // For performance reasons, we need the enclosing statement without overrides

javascript/ql/lib/semmle/javascript/Extend.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for reasoning about `extend`-like functions.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Externs.qll

@@ -36,7 +36,7 @@
  * Array.prototype.length;
  * </pre>
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Files.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with files and folders. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Functions.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with functions. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll

@@ -1,7 +1,7 @@
 /**
  * Provides predicates for associating qualified names with data flow nodes.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript
@@ -357,7 +357,7 @@ module AccessPath {
      * Gets a variable that is relevant for the computations in the `GetLaterAccess` module.
      * This predicate restricts as much as it can, but without depending on `getAVariableRef`.
      */
-    overlay[caller]
+    overlay[caller?]
     pragma[inline]
     private SsaVariable getARelevantVariableSimple() {
       // The variable might be used where `getLaterBaseAccess()` is called.
@@ -409,7 +409,7 @@ module AccessPath {
    * }
    * ```
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::Node getAReferenceTo(Root root, string path) {
     path = fromReference(result, root) and
@@ -433,7 +433,7 @@ module AccessPath {
    * })(NS = NS || {});
    * ```
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::Node getAReferenceTo(string path) {
     path = fromReference(result, DataFlow::globalAccessPathRootPseudoNode())
@@ -455,7 +455,7 @@ module AccessPath {
    * }
    * ```
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::Node getAnAssignmentTo(Root root, string path) {
     path = fromRhs(result, root) and
@@ -477,7 +477,7 @@ module AccessPath {
    *  })(foo = foo || {});
    * ```
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::Node getAnAssignmentTo(string path) {
     path = fromRhs(result, DataFlow::globalAccessPathRootPseudoNode())
@@ -488,7 +488,7 @@ module AccessPath {
    *
    * See `getAReferenceTo` and `getAnAssignmentTo` for more details.
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::Node getAReferenceOrAssignmentTo(string path) {
     result = getAReferenceTo(path)
@@ -501,7 +501,7 @@ module AccessPath {
    *
    * See `getAReferenceTo` and `getAnAssignmentTo` for more details.
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::Node getAReferenceOrAssignmentTo(Root root, string path) {
     result = getAReferenceTo(root, path)
@@ -530,7 +530,7 @@ module AccessPath {
   /**
    * Gets a `SourceNode` that refers to the same value or access path as the given node.
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   DataFlow::SourceNode getAnAliasedSourceNode(DataFlow::Node node) {
     exists(DataFlow::SourceNode root, string accessPath |

javascript/ql/lib/semmle/javascript/HTML.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with HTML documents. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/JSDoc.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with JSDoc comments. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/JSON.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with JSON data.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/JSX.qll

@@ -1,7 +1,7 @@
 /**
  * Provides classes for working with JSX code.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Lines.qll

@@ -4,7 +4,7 @@
  * This information is only available for snapshots that have been extracted with
  * the `--extract-program-text` flag.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/Locations.qll

@@ -1,5 +1,5 @@
 /** Provides classes for working with locations and program elements that have locations. */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript
@@ -32,7 +32,7 @@ final class Location extends @location_default {
   int getNumLines() { result = this.getEndLine() - this.getStartLine() + 1 }
 
   /** Holds if this location starts before location `that`. */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   predicate startsBefore(Location that) {
     exists(string f, int sl1, int sc1, int sl2, int sc2 |
@@ -46,7 +46,7 @@ final class Location extends @location_default {
   }
 
   /** Holds if this location ends after location `that`. */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   predicate endsAfter(Location that) {
     exists(string f, int el1, int ec1, int el2, int ec2 |

javascript/ql/lib/semmle/javascript/Modules.qll

@@ -3,7 +3,7 @@
  * ECMAScript 2015-style modules, and the older CommonJS and AMD-style
  * modules.
  */
-overlay[local]
+overlay[local?]
 module;
 
 import javascript

javascript/ql/lib/semmle/javascript/NodeJS.qll

@@ -17,7 +17,7 @@ private import semmle.javascript.dataflow.internal.DataFlowNode
  *   process.stdout.write(fs.readFileSync(process.argv[i], 'utf8'));
  * ```
  */
-overlay[local]
+overlay[local?]
 class NodeModule extends Module {
   NodeModule() {
     is_module(this) and
@@ -234,7 +234,7 @@ predicate findNodeModulesFolder(Folder f, Folder nodeModules, int distance) {
 /**
  * A Node.js `require` variable.
  */
-overlay[local]
+overlay[local?]
 private class RequireVariable extends Variable {
   RequireVariable() {
     this = any(ModuleScope m).getVariable("require")
@@ -247,7 +247,7 @@ private class RequireVariable extends Variable {
   }
 }
 
-overlay[local]
+overlay[local?]
 private predicate isModuleModule(EarlyStageNode nd) {
   exists(ImportDeclaration imp | imp.getRawImportPath() = "module" |
     nd = TDestructuredModuleImportNode(imp)
@@ -261,7 +261,7 @@ private predicate isModuleModule(EarlyStageNode nd) {
   )
 }
 
-overlay[local]
+overlay[local?]
 private predicate isCreateRequire(EarlyStageNode nd) {
   exists(PropAccess prop |
     isModuleModule(TValueNode(prop.getBase())) and
@@ -291,7 +291,7 @@ private predicate isCreateRequire(EarlyStageNode nd) {
 /**
  * Holds if `nd` may refer to `require`, either directly or modulo local data flow.
  */
-overlay[local]
+overlay[local?]
 cached
 private predicate isRequire(EarlyStageNode nd) {
   exists(VarAccess access |
@@ -334,7 +334,7 @@ private predicate isRequire(EarlyStageNode nd) {
  * require('fs')
  * ```
  */
-overlay[local]
+overlay[local?]
 class Require extends CallExpr, Import {
   Require() { isRequire(TValueNode(this.getCallee())) }