Fix/enhance MODELS.md #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, There.
Ii fixed a small problem with the MODELS.md file, and tried to format it better to make it easier for future updates.
Also, please tag a new version (0.2.0 or 0.1.5, maybe?), so the latest changes can be pushed to AUR.
I am also finishing an PR with proper DKMS support. There is a very old PR (#31) but it seems that the author abandoned it. While reading your comments over there, it seemed to me that you prefer to add the new files to a
contribfolder, right? Personally, I just think this makes more complicated, since some files will need to be copied during installation, and also for discovery (contrib/dkms, as you proposed). But if this is the only way you would accept it, then I will comply.Thanks again for the drivers.
Regards