Skip to content

Conversation

@dfokina
Copy link
Contributor

@dfokina dfokina commented Dec 8, 2025

fixes #10203

Proposed Changes:

  • Adding the missing docs for RegexTextExtractor to several versions of our documentation
  • Adding these pages to sidebars and overviews as well

How did you test it?

  • Tested the code samples succesfully

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@dfokina dfokina requested a review from a team as a code owner December 8, 2025 10:49
@dfokina dfokina requested review from anakin87 and removed request for a team December 8, 2025 10:49
@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
haystack-docs Ready Ready Preview Comment Dec 8, 2025 10:50am


### Handling no matches

By default, when the pattern doesn't match, the component returns an empty dictionary `{}`. You can change this behavior with the `return_empty_on_no_match` parameter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: IMO for technical documentation avoiding contractions sounds much better

Suggested change
By default, when the pattern doesn't match, the component returns an empty dictionary `{}`. You can change this behavior with the `return_empty_on_no_match` parameter:
By default, when the pattern does not match, the component returns an empty dictionary `{}`. You can change this behavior with the `return_empty_on_no_match` parameter:

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: just a nitpick comment/suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RegexTextExtractor docs

3 participants