[ui] Try to fix weird resize loop on asset plot #32978
Open
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit dd209d3. |
hellendag
commented
Dec 4, 2025
| import {useRGBColorsForTheme} from '../app/useRGBColorsForTheme'; | ||
|
|
||
| ChartJS.register(CategoryScale, LinearScale, LineElement, PointElement, TimeScale); | ||
| ChartJS.register(CategoryScale, LinearScale, LineElement, PointElement, TimeScale, ChartTooltip); |
Member
Author
There was a problem hiding this comment.
This wasn't registering the tooltip plugin, but it is used in the options. So I added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
One of our users is reporting strange behavior with asset plot charts, where the chart automatically resizes itself smaller and smaller.
I'm going to try to fix this by putting a wrapper div with a set height, and remove the
widthandheightprops from theLinecomponent.I'm not able to repro the issue myself, but this approach seems worth a try.
How I Tested These Changes
View asset plots, verify that they render properly.