test(commands): centralize all --help tests in a file to dedup code #1726
+74
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-11-0 #1726 +/- ##
==========================================
Coverage ? 97.84%
==========================================
Files ? 60
Lines ? 2604
Branches ? 0
==========================================
Hits ? 2548
Misses ? 56
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
test-help
branch
2 times, most recently
from
097ef1f to
6c3ef01
Compare
This was referenced Dec 13, 2025
bearomorphism
force-pushed
the
test-help
branch
from
6c3ef01 to
ecd05a4
Compare
bearomorphism
force-pushed
the
test-help
branch
from
ecd05a4 to
ce12748
Compare
bearomorphism
commented
Dec 13, 2025
Comment on lines
-22
to
-25
| skip_below_py_3_13 = pytest.mark.skipif( | ||
| sys.version_info < (3, 13), | ||
| reason="The output message of argparse is different between Python 3.13 and lower than Python 3.13", | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
The variable name itself does not reflect why we want to set this variable... this may make it hard for future contributors to understand the code correctly
bearomorphism
commented
Dec 13, 2025
Comment on lines
+41
to
+46
| monkeypatch.setenv("COLUMNS", "80") | ||
| monkeypatch.setenv("TERM", "dumb") | ||
| monkeypatch.setenv("LC_ALL", "C") | ||
| monkeypatch.setenv("LANG", "C") | ||
| monkeypatch.setenv("NO_COLOR", "1") | ||
| monkeypatch.setenv("PAGER", "cat") |
Collaborator
Author
There was a problem hiding this comment.
Copied from AI output. I know COLUMNS is necessary, but not sure for the rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test improvements
skip_below_py_3_13and missing forced consistent environment variables to reduce the chance of unnecessary file regression test failures.