Skip to content

test: remove skip_below_py_3_10 #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bearomorphism wants to merge 1 commit into from
+0 −17
Closed

test: remove skip_below_py_3_10 #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/commands/test_example_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from pytest_mock import MockerFixture

from commitizen import cli, commands
from tests.utils import skip_below_py_3_10


def test_example(config, mocker: MockerFixture):
Expand All @@ -13,7 +12,6 @@ def test_example(config, mocker: MockerFixture):
write_mock.assert_called_once()


@skip_below_py_3_10
def test_example_command_shows_description_when_use_help_option(
mocker: MockerFixture, capsys, file_regression
):
Expand Down
2 changes: 0 additions & 2 deletions tests/commands/test_info_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from pytest_mock import MockerFixture

from commitizen import cli, commands
from tests.utils import skip_below_py_3_10


def test_info(config, mocker: MockerFixture):
Expand All @@ -13,7 +12,6 @@ def test_info(config, mocker: MockerFixture):
write_mock.assert_called_once()


@skip_below_py_3_10
def test_info_command_shows_description_when_use_help_option(
mocker: MockerFixture, capsys, file_regression
):
Expand Down
2 changes: 0 additions & 2 deletions tests/commands/test_init_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from commitizen import cli, cmd, commands
from commitizen.__version__ import __version__
from commitizen.exceptions import InitFailedError, NoAnswersError
from tests.utils import skip_below_py_3_10

if TYPE_CHECKING:
from pytest_mock import MockFixture
Expand Down Expand Up @@ -275,7 +274,6 @@ def test_empty_input_returns_default(self, mocker: MockFixture, config: BaseConf
assert result == "$version" # This is the default format from DEFAULT_SETTINGS


@skip_below_py_3_10
def test_init_command_shows_description_when_use_help_option(
mocker: MockFixture, capsys, file_regression
):
Expand Down
2 changes: 0 additions & 2 deletions tests/commands/test_ls_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from pytest_mock import MockerFixture

from commitizen import cli, commands
from tests.utils import skip_below_py_3_10


def test_list_cz(config, mocker: MockerFixture):
Expand All @@ -13,7 +12,6 @@ def test_list_cz(config, mocker: MockerFixture):
write_mock.assert_called_once()


@skip_below_py_3_10
def test_ls_command_shows_description_when_use_help_option(
mocker: MockerFixture, capsys, file_regression
):
Expand Down
2 changes: 0 additions & 2 deletions tests/commands/test_schema_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from pytest_mock import MockerFixture

from commitizen import cli, commands
from tests.utils import skip_below_py_3_10


def test_schema(config, mocker: MockerFixture):
Expand All @@ -13,7 +12,6 @@ def test_schema(config, mocker: MockerFixture):
write_mock.assert_called_once()


@skip_below_py_3_10
def test_schema_command_shows_description_when_use_help_option(
mocker: MockerFixture, capsys, file_regression
):
Expand Down
2 changes: 0 additions & 2 deletions tests/commands/test_version_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from commitizen import cli, commands
from commitizen.__version__ import __version__
from commitizen.config.base_config import BaseConfig
from tests.utils import skip_below_py_3_10


def test_version_for_showing_project_version_error(config, capsys):
Expand Down Expand Up @@ -105,7 +104,6 @@ def test_version_use_version_provider(
mock.set_version.assert_not_called()


@skip_below_py_3_10
def test_version_command_shows_description_when_use_help_option(
mocker: MockerFixture, capsys, file_regression
):
Expand Down
5 changes: 0 additions & 5 deletions tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
if TYPE_CHECKING:
from commitizen.version_schemes import Increment, Prerelease

skip_below_py_3_10 = pytest.mark.skipif(
sys.version_info < (3, 10),
reason="The output message of argparse is different between Python 3.10 and lower than Python 3.10",
)

skip_below_py_3_13 = pytest.mark.skipif(
sys.version_info < (3, 13),
reason="The output message of argparse is different between Python 3.13 and lower than Python 3.13",
Expand Down