Show progress for currently selected Profile #1960
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
real-yfprojects
left a comment
real-yfprojects
left a comment
There was a problem hiding this comment.
Thank you for the PR!
| def set_log(self, text=''): | ||
| self.logText.setText(text) | ||
| self.logText.repaint() | ||
| profile = extract_profile_name(text) |
Collaborator
There was a problem hiding this comment.
Why don't you modify the log signal similar to the progress signal. We shouldn't inexplicitely expect a specific log message format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Functions used to log the progress, check for the selected profile, before rendering them
Related Issue
#1824
Motivation and Context
Improves user experience by filtering the progress logged
How Has This Been Tested?
Scheduling backups for multiple profiles, but logs and progress for only selected profile is shown
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.