-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(ecs): enableDeploymentAlarms should mutate the alarmNames property #36309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(ecs): enableDeploymentAlarms should mutate the alarmNames property #36309
Conversation
concat() does not mutate the existing array, while push() does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
||||||||||||||
|
||||||||||||||
|
This PR is currently blocked by this:
You will need to add/update integ test to unblock this or if you think integ tests are not necessary, please follow the suggestion #36309 (review) |
Thanks. I've added basic coverage for this case in the existing integration test as it was not exercised there before. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Issue #36308
Closes #36308
Reason for this change
Fixes a silent bug in the ecs module.
Description of changes
The code is mistakenly using
concat()which returns a new array rather than modifying the existing one (which was the original intent of the code).Describe any new or updated permissions being added
n/a
Description of how you validated changes
test case added
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license