Skip to content

Conversation

@saehejkang
Copy link
Contributor

@saehejkang saehejkang commented Dec 8, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Updates to image prune for consistency with how other prune commands are done. Added missing test cases as well for the command

Relates to the discussion from #914

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@jglogan
Copy link
Contributor

jglogan commented Dec 9, 2025

Ready to move out of draft?

@saehejkang saehejkang marked this pull request as ready for review December 10, 2025 02:16
@saehejkang
Copy link
Contributor Author

saehejkang commented Dec 10, 2025

I think I am getting the same error mentioned here for the testImagePruneDanglingImages test. It is again, a test that combines an existing image with a run command.

✘ Test testImagePruneDanglingImages() recorded an issue at TestCLIImagesCommand.swift:414:6: Caught error: executionFailed("command failed: \u{1B}[33mWarning!\u{1B}[0m Running debug build. Performance may be degraded.\nError: internalError: \"failed to create container\" (cause: \"notFound: \"image ghcr.io/apple/containerization/vminit:0.16.2 not found\"\")\n")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants