Skip to content

Refactor subprocess creation to simplify code #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gbtami wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor subprocess creation to simplify code #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 10 additions & 21 deletions src/acp/transports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,27 +63,16 @@ async def spawn_stdio_transport(
if env:
merged_env.update(env)

if limit is None:
process = await asyncio.create_subprocess_exec(
command,
*args,
stdin=aio_subprocess.PIPE,
stdout=aio_subprocess.PIPE,
stderr=stderr,
env=merged_env,
cwd=str(cwd) if cwd is not None else None,
)
else:
process = await asyncio.create_subprocess_exec(
command,
*args,
stdin=aio_subprocess.PIPE,
stdout=aio_subprocess.PIPE,
stderr=stderr,
env=merged_env,
cwd=str(cwd) if cwd is not None else None,
limit=limit,
)
process = await asyncio.create_subprocess_exec(
command,
*args,
stdin=aio_subprocess.PIPE,
stdout=aio_subprocess.PIPE,
stderr=stderr,
env=merged_env,
cwd=str(cwd) if cwd is not None else None,
limit=limit,
)

if process.stdout is None or process.stdin is None:
process.kill()
Expand Down
Loading