Remove @types/glob to fix TypeScript compilation failure #145
+852
−436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @types/glob package was upgraded to v9.0.0 in PR #139, which is a stub package that expects glob to provide its own type definitions. This caused TypeScript compilation to fail with "Cannot find type definition file for 'glob'". Since glob now provides its own types, removing @types/glob resolves the issue. Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test.yml flow after merging PR 139
Remove @types/glob to fix TypeScript compilation failure
Dec 11, 2025
felickz
approved these changes
Dec 11, 2025
Contributor
felickz
left a comment
felickz
left a comment
There was a problem hiding this comment.
Removing a dependency fixes a broken test/build is a 💯 fix from me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #139 upgraded
@types/globto v9.0.0, which is a stub package directing users to the built-in types fromglobitself. This broke TypeScript compilation witherror TS2688: Cannot find type definition file for 'glob'.Changes
@types/globfromdevDependenciesinpackage.jsonpackage-lock.jsonto reflect the removaldist/artifactsThe
globpackage already provides its own type definitions, making the separate@typespackage unnecessary and conflicting.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/microsoft/component-detection/releases/latest/usr/local/bin/node node /home/REDACTED/work/component-detection-dependency-submission-action/component-detection-dependency-submission-action/node_modules/.bin/jest(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.