Skip to content

Conversation

@sdil
Copy link

@sdil sdil commented Dec 7, 2025

Motivation / Background

The example code is creating subscriber but using pub as its variable name. IMO, it would be more descriptive to use the word sub when creating subscriber.

Detail

N/A

Alternative approaches considered (if applicable)

N/A

Checklist

The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:

  • I wrote tests for the changes.
  • All tests are passing.
    • If you are testing a Pub/Sub, you can start Docker with make up.
    • You can start with make test_short for a quick check.
    • If you want to run all tests, use make test.
  • Code has no breaking changes.
  • (If applicable) documentation on watermill.io is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant