SNES: Add support for ExLoRom mapping #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This format is used by ROM hacks, and is supported by at least Snes9x and bsnes. It's indicated by having a copy of the header at 0x400000 with a LoRom map mode. The removed check for map mode 0x22 triggered in S-DD1 games, but their memory layout is very different from ExLoRom. Their mapping is handled by `MapBsxMemoryPack` instead of the regular `RegisterHandlers` code anyway, so the setting of that flag had no effect other than what's reported in the log window, but it was removed to prevent future confusion.
Contributor
Author
|
As brought up on Discord: I'm additionally licensing this code under the terms of BSD-0, and explicitly allow it to be relicensed in any way if desired in the future, and without any need of attribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a slightly improved version of the patch I mentioned a while back on the snesdev discord.)
This format is used by ROM hacks, and is supported by at least Snes9x and bsnes. It's indicated by having a copy of the header at 0x400000 with a LoRom map mode.
The removed check for map mode 0x22 triggered in S-DD1 games, but their memory layout is very different from ExLoRom. Their mapping is handled by
MapBsxMemoryPackinstead of the regularRegisterHandlerscode anyway, so the setting of that flag had no effect other than what's reported in the log window, but it was removed to prevent future confusion.