Skip to content

Conversation

@rpanackal
Copy link
Member

@rpanackal rpanackal commented Dec 8, 2025

Context

AI/ai-sdk-java-backlog#ISSUENUMBER.

OrchestrationSpringEmbeddingModel was release as Beta, simply to gracefully accommodate any unforeseen breaking changes.

Since, no beta objects are in public api contract, its now marked stable.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@rpanackal rpanackal changed the title Remove @Beta from OrchestrationSpringEmbeddingModel fix: [Orchestration] Remove @Beta from OrchestrationSpringEmbeddingModel Dec 8, 2025
Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpanackal
Copy link
Member Author

rpanackal commented Dec 8, 2025

what about related classes e.g https://github.com/SAP/ai-sdk-java/blob/main/orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationEmbeddingRequest.java ?

This needs some work before It can be marked stable.

I left this as @Beta since

  • we only support float response encoding format (also affect the related OrchestrationEmbeddingResponse).Maybe this is fine since we received no user request for base64 and binary types.
  • we couldn't test the available models inOrchestrationEmbeddingModel via scenario tests. The model list api was very out of sync at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants