-
Notifications
You must be signed in to change notification settings - Fork 217
Maniacs Patch - Zoom Command #3499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Implements Maniac Zoom support, allowing zooming of specific map layers with configurable center, rate, duration, and layer. Adds new interpreter command, zoom state management in Game_Screen, and rendering logic in Graphics to apply zoom transforms to selected layers. This enables compatibility with Maniacs Patch zoom event commands. Maniacs Patch - Zoom Command Implements Maniac Zoom support, allowing zooming of specific map layers with configurable center, rate, duration, and layer. Adds new interpreter command, zoom state management in Game_Screen, and rendering logic in Graphics to apply zoom transforms to selected layers. This enables compatibility with Maniacs Patch zoom event commands.
|
While I appreciate all your contributions and I just havnt found time to look at all of them I have to criticize the AI usage especially in the commit messages and the pull request texts. These texts are verbose and unfun to read. Everything after Maniac Zoom feature implementation could be removed and just a remark "see commit message" added which mentions the most relevant parts. (or just copy-paste the commit message into the PR description. Don't reword anything, is a waste of time).
Same for the commit message. Make the texts short bullet points. Keep it to a bare minimum (except when you think that a feature is so complecated it is worth a longer explanation) Remove everything that is redundant like this last sentence:
|
|
removed all the automatic text from the commit description. I was simply tired after fighting the code all night and let copilot autofill it. |
The highest layer attatched should be the frame one, not overlay.
Implements Maniac Zoom support, allowing zooming of specific map layers with configurable center, rate, duration, and layer Itself.
Right now lacks support on savefiles.