-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Infinite scroll SEO #6598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Infinite scroll SEO #6598
Conversation
ad1d2d6 to
b620bea
Compare
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/+my-library/my-follows/my-followers.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/+my-library/my-follows/my-subscriptions.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/+my-library/my-video-playlists/my-video-playlists.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/shared/shared-video-miniature/videos-list.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/shared/shared-video-miniature/videos-selection.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/shared/standalone-notifications/user-notifications.component.ts
Outdated
Show resolved
Hide resolved
|
@Chocobozzz I did a self-review and found some minor style changes. If you're okay with this implementation I'll fix them. |
|
@Chocobozzz Any thoughts on this? If this feature is wanted I'll do a cleanup and fix merge conflicts. |
We're interested in the feature but unfortunately we don't have time to review it yet |
812fa93 to
b9dadbf
Compare
Add a "Load more" button in the bottom to help search engine bots to navigate to the next page. In order to debug this functionality, add ?finiteScroll=true to the URL.
hasMoreItems has to be called before bumping the current page in order to work accordingly.
b9dadbf to
1ac7373
Compare
c7a1037 to
66db1ea
Compare
66db1ea to
1066288
Compare
|
Hi and sorry for the (very) late review. If so, can we implement instead a logic for robots where we inject a |
Yes, the issue persists and according to #6210 (comment) we doesn't seem to be alone.
We can always try, but it's not according to Googles recommendations. A simpler solution would be to create separate logic for the |
Nice catch.
What if we mix the solutions:
? And how would you use |
What would be the difference from this PR:s solution? I think it would be simpler create a new directive only used in scenarios where SEO is needed. A one size fits all solution was hard to get clean, at least one year ago.
Yes, and to to know when to update the URL. Google also recommends to:
So the best scenario would be to have a pagination navigation, rather than a simple "Load more" button. |
|
(sorry for my late answer)
The difference is that we add the "Load more" button directly in the Browse Videos component, not inside the infinite scroll directive. With the proposed solution, we don't change how we load videos and still use the infinite scroll directive. It seems to me this solution is easier to add. Anyway this is just implementation details, I think we agree on the global solution. If you want to give it a try, don't hesitate to force push on this PR or create another one. |
Description
Adds a "Load more" button on the bottom of MyInfiniteScrollerComponent. For a regular user the behavior should be the same.
Behavior for bots:
page?{currentPage++}Background
Thoughts during the path
Todo
Related issues
#6332
Has this been tested?
To test it manually, add a "?page=1" query param to a route which has infinite scroll
Screenshots