Skip to content

Conversation

@YoSmudge
Copy link

@YoSmudge YoSmudge commented May 2, 2016

Support updating profiles

@ChimeraCoder
Copy link
Owner

Thanks for adding! Not sure why the CI failed on tip - let's try this again.

@ChimeraCoder ChimeraCoder reopened this May 9, 2016
@ChimeraCoder
Copy link
Owner

Okay, mind rebasing this onto master? The tests should pass now.

@YoSmudge
Copy link
Author

YoSmudge commented May 9, 2016

Hey,

Rebased on master now.

As for the tests, I believe the failing CI was down to requiring tests to pass on Golang tip. Since tip is the development version of Golang it's often unstable, the actual test failure was down to the latest commit on tip completely breaking the compiler.

While testing against tip is useful, this instability can lead to flapping tests and random failures, what I tend to do in my .travis.yml file is add

go:
  - 1.5
  - 1.6
  - tip

matrix:
  allow_failures:
    - go: tip

This will run the tests against tip, but won't fail the build if only tip fails.

Thanks

@muesli
Copy link
Collaborator

muesli commented Sep 3, 2017

@YoSmudge: Would you mind splitting that up in two PRs and rebasing / squashing everything? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants