-
Notifications
You must be signed in to change notification settings - Fork 474
Feature/traces sampler #11497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Feature/traces sampler #11497
Conversation
…try configuration. Add config for the default OpenTelemetry trace sampling options.
|
@openPablo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Hi @openPablo , Thank you for taking the time to submit this PR. I agree that sampling is essential, particularly in high-volume scenarios. I believe the OpenTelemetry SDK should respect OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG directly, without requiring us to manually read the environment variables and configure the sampler ourselves |
|
Hey @RohitRanjanMS, thank you for taking the time to read through my feature request and PR. I'm not sure I understand you correctly. Should I edit the code so that it works with environment variables, without manually setting config flags? |
Issue describing the changes in this PR
resolves #11496
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md