-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Open
Labels
Open SourceThe issue or pull reuqest is related to the open source packages of Tiptap.The issue or pull reuqest is related to the open source packages of Tiptap.
Description
Affected Packages
core, static-renderer
Version(s)
3.12
Bug Description
Adding a color to an underlined text does not change the color of the underline. This is because the underline is rendered outside.
See the failing test case (PR).
FAIL packages/static-renderer/__tests__/json-string.spec.ts > static render json to string (with prosemirror) > supports underline and spans
AssertionError: expected '<p><u><span style="color: #ED1F1F">Un…' to be '<p><span style="color: #ED1F1F"><u>Un…' // Object.is equality
Expected: "<p><span style="color: #ED1F1F"><u>Underlined</u></span></p>"
Received: "<p><u><span style="color: #ED1F1F">Underlined</span></u></p>"
❯ packages/static-renderer/__tests__/json-string.spec.ts:293:18
291| })
292|
293| expect(html).toBe('<p><span style="color: #ED1F1F"><u>Underlined</u></span></p>')
| ^
294| })
295|
Browser Used
Chrome
Code Example URL
No response
Expected Behavior
The underline is rendered outside.
Additional Context (Optional)
No response
Dependency Updates
- Yes, I've updated all my dependencies.
Metadata
Metadata
Assignees
Labels
Open SourceThe issue or pull reuqest is related to the open source packages of Tiptap.The issue or pull reuqest is related to the open source packages of Tiptap.