thanos query, flag --endpoint is deprecated?

[danislav]

Reading https://github.com/thanos-io/thanos/blob/main/docs/components/query.md:
All examples use --endpoint, but yet, in the list of flags it says it's deprecated:
--endpoint=<endpoint> ... (Deprecated)

If it's deprecated, what would you recommend to use instead?

[dosubot[bot]]

Hello @danislav! I'm here to help you with any bugs, questions, or contributions you have. Let's tackle this together!

The --endpoint flag in Thanos Query is indeed deprecated. You should use the --endpoint.sd-config flag instead. This allows you to specify a configuration file with endpoint definitions, supporting dynamic service discovery and configuration reloads for more flexibility ^[1].

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}

[danislav]

Thank you, dear Bot 😄
So why in all the examples in the document there is this flag?

[MichaHoffmann]

It still works and I was too lazy too update the document yet 🙈

[danislav]

I am lazy too so I totally understand 😅
If I can find some free time - as a new to thanos query guy reading the doc - I'll try to propose some updates.
For example: file-sd - also deprecated later. I would add an example using --endpoint.sd-config instead of --store.sd-files
Thank you for the help! I will try to setup the service using the --endpoint.sd-config or --endpoint.sd-config-file
❤️

[deadhexagon]

Since there doesn't appear to be any documentation on the --endpoint.sd-config expected YAML layout yet, can someone provide an example of the structure of this file? Thank you.

[deadhexagon]

I managed to get a small test going:

endpoints:
- address: <thanos-store-api-host>:<port>
- address: <thanos-receive-api-host>:<port>

I'd be interested in a bigger example though, that shows all the available options.

[MichaHoffmann]

At this point in time there are the options "group" and "strict" both booleans to mirror the old --endpoint-group/--endpoint-strict options

[danislav]

So actually the new flag is not yet in the latest stable, right?
It's documented but you still can't use --endpoint.sd-config-file in v.0.37.2 🤔
2367777

[MichaHoffmann]

Yes it's not yet released I think - it will be in next release

[rpelissi]

Hi,
With thanos Querier 0.39.2 we use to configure our endpoints with --store.sd-files=, like:

---
- targets: ["dnssrv+_querier._prod._prometheus._sd"]

but for some reasons it does not seems to work anymore (the doc mention it's deprecated), so we try the option --endpoint.sd-config-file= but we cannot find the proper file syntax for dns service discorery.. we know that --endpoint="dnssrv+_querier._stg._prometheus._sd" is working but.... it is supposed to be deprecated too..

The doc https://thanos.io/v0.39/components/query.md is not clear enough to understand what is required for the in --endpoint.sd-config-file with dns discovery....
Can you help on this please?
Thanks!