Skip to content

Conversation

@cb-nsrinivasa
Copy link

@cb-nsrinivasa cb-nsrinivasa commented Dec 1, 2025

Changes

add hostUsers to pod template

verified using k8 1.33 (kind create cluster --image kindest/node:v1.33.4)

#9083
shipwright-io/build#2012
#9001

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

add hostUsers to pod template

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 1, 2025
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign imjasonh after the PR has been reviewed.
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cb-nsrinivasa cb-nsrinivasa mentioned this pull request Dec 1, 2025
8 tasks
@vdemeester
Copy link
Member

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 1, 2025
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, I wonder how it will act on k8s version lower than 1.33, but I think the e2e tests would tell.
On that note, can we add an e2e test ?

@vdemeester
Copy link
Member

We will also need to fill the release-note entry.

@cb-nsrinivasa
Copy link
Author

cb-nsrinivasa commented Dec 1, 2025

SGTM, I wonder how it will act on k8s version lower than 1.33

i tested it with 1.32, 1.28

TaskRun.yaml

apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
  name: hello-world-run-host
spec:
  taskRef:
    name: hello-worlds
  podTemplate:
    hostUsers: true

the pod does not have the hostUsers field


apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
  name: inline-taskrun
spec:
  podTemplate:
    hostUsers: true
  taskSpec:
    steps:
      - name: say-hello
        image: alpine:3
        script: |
          echo "Hello from inline TaskSpec"

i dont see any failures in the pod

k get TaskRun
NAME             SUCCEEDED   REASON      STARTTIME   COMPLETIONTIME
inline-taskrun   True        Succeeded   28s         12s

for 1.32, 1.28 the hostUsers field is not present in the pod yaml
for 1.33 the hostUsers field is present

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants