-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add hostUsers #9190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add hostUsers #9190
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind feature |
vdemeester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, I wonder how it will act on k8s version lower than 1.33, but I think the e2e tests would tell.
On that note, can we add an e2e test ?
|
We will also need to fill the release-note entry. |
i tested it with 1.32, 1.28
the pod does not have the i dont see any failures in the pod for 1.32, 1.28 the |
Changes
add hostUsers to pod template
verified using k8 1.33 (kind create cluster --image kindest/node:v1.33.4)
#9083
shipwright-io/build#2012
#9001
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes