JdbcAggregateOperations delete by query

[micopiira]

While comparing R2dbcEntityOperations and JdbcAggregateOperations I noticed that R2dbcEntityOperations has a method to delete entities by query: R2dbcEntityOperations#delete(org.springframework.data.relational.core.query.Query,java.lang.Class) but JdbcAggregateOperations does not.

I'm proposing to add following method to the JdbcAggregateOperations interface:

void delete(org.springframework.data.relational.core.query.Query query, Class<?> domainType);

[ivamly]

Hi, @schauder!

Could I work on this? If so, is there any additional information I should know before I start working on it?

Thanks!

[schauder]

Sure, go ahead.

[ivamly]

Hi @schauder ! I just wanted to confirm that my understanding of the implementation is correct. Here's what I think needs to be done:

1. The delete method will be executed via DataAccessStrategy, as all methods that use Query are executed in this way.
2. We need to add a method in SqlGenerator to generate the SQL query for the delete operation.
3. A method needs to be added in SqlParametersFactory to retrieve the parameters based on the provided Query.
4. Finally, we will execute the delete operation via operations.update().

Is my understanding correct? Any advice would be greatly appreciated. Thanks!

[schauder]

Sounds good.

[micopiira]

@ivamly Any progress on this one?

[ivamly]

@micopiira Hi! No, I'm sorry, I don't think I'll be able to do it any time soon.

[ghgh415263]

@ivamly Would it be okay if I worked on this issue?

[schauder]

Sure, why not.

[ghgh415263]

Hello! I'm working on this issue and I have questions

1. I'm implementing function. It currently throws an exception ("Delete requires criteria to avoid full-table delete") if the query’s criteria are absent. I'm wondering if there’s a more idiomatic or effective approach to handle that scenario. (or to accept an empty criteria )
2. Is it a good approach to first fetch IDs using a select with query and then use those IDs to perform a deleteAllByIds operation to delete an aggregate and its associated sub-entities? Or would it be better to simply delete the root aggregate only, without deleting the sub-entities?

[schauder]

While probably not often used I don't see anything inherently wrong with deleting with an empty criteria. After all we also have deleteAll in the CrudRepository.

And we absolutely have to delete sub entities with the aggregate root.

The proposed tests seem fine.

[schauder]

I discussed this topic with the team and we decided that we are not going to produce events for deleted aggregates. Therefore we can and should delete them directly without the extra step of first loading the aggregate ids.

[ghgh415263]

So it means I only need to run a single DELETE query on table, and the related sub-entities will remain unaffected?