Devcontainer image still using bullseye

[TyceHerrman]

What's the reason the devcontainer image in .devcontainer/docker-compose-devcontainer.yml is still using bullseye? Could it be updated to bookworm?

[linear]

WEB-4157 Devcontainer image still using bullseye

[iainsproat]

No reason. It should also be bumped to node 22.

I've created a PR to bump it. Please do test the devcontainer on that branch and let me know if it works: #5340

[TyceHerrman]

I'm getting an error during yarn link step that, according to the logs in the container, says that node-gyp can't be found and is required by deasync, which looks like it was added to the server package.json very recently. I saw some threads online with others mentioning node-gyp missing from the reference Docker image they were using.

tl;dr, I think node-gyp is probably missing from this new image and needs to be installed during devcontainer creation before postCreateCommand is invoked.

[TyceHerrman]

Seems like couple things need to happen. Based on abbr/deasync#181 and comment abbr/deasync#181 (comment), yarnrc.yml needs updated with

packageExtensions:
    # deasync didn't add node-gyp as a direct dependency so it fails to build in
    # Yarn (https://github.com/yarnpkg/berry/issues/5804), so extend its
    # pkg.json config here.
    deasync@*:
        dependencies:
            node-gyp: 'latest'

Additionally, python3 and build-essential need to be installed for node-gyp. I did this by adding

"onCreateCommand": "sudo apt-get update && sudo apt-get install -y build-essential python3 && sudo rm -rf /var/lib/apt/lists/*", above postCreateCommand in devcontainer.json.

With those two changes, the devcontainer worked for me.

[TyceHerrman]

A variant on the above that I'm using: I made a new shell script, setup.sh in .devcontainer since I want to do some other installs during onCreateCommand step, and so that step was getting long:

#!/bin/bash
sudo apt-get update
sudo apt-get install -y build-essential python3
sudo install -dm 755 /etc/apt/keyrings
wget -qO - https://mise.jdx.dev/gpg-key.pub | gpg --dearmor | sudo tee /etc/apt/keyrings/mise-archive-keyring.gpg 1> /dev/null
echo 'deb [signed-by=/etc/apt/keyrings/mise-archive-keyring.gpg arch=amd64,arm64] https://mise.jdx.dev/deb stable main' | sudo tee /etc/apt/sources.list.d/mise.list
sudo apt-get update
sudo apt-get install -y mise
sudo rm -rf /var/lib/apt/lists/*
echo 'eval "$(mise activate bash)"' >> ~/.bashrc
eval "$(mise activate bash)"
mise use -g neovim```

then onCreateCommand line is just:  `"onCreateCommand": "bash ./.devcontainer/setup.sh",`

[TyceHerrman]

@iainsproat is there any other feedback you want on this?

[TyceHerrman]

@iainsproat checking in on whether you have any thoughts on this.