-
-
Notifications
You must be signed in to change notification settings - Fork 109
Open
Labels
bugErroneous behavior in existing featuresErroneous behavior in existing featureslow hanging fruitTask that should be easy to implement - perfect for people that want to start contributing.Task that should be easy to implement - perfect for people that want to start contributing.
Description
When field names passed in overrides are ambiguous (due to name comparator used), we currently use this piece of code:
Lines 172 to 185 in a55f1df
| runtimeField match { | |
| case TransformerOverride.Unused => | |
| ".withFieldUnused(...)" | |
| case TransformerOverride.Const(_) => | |
| s".withFieldConst(_.$anotherToName, ...)" | |
| case TransformerOverride.ConstPartial(_) => | |
| s".withFieldConstPartial(_.$anotherToName, ...)" | |
| case TransformerOverride.Computed(_, _, _) => | |
| s".withFieldComputed(_.$anotherToName, ...)" | |
| case TransformerOverride.ComputedPartial(_, _, _) => | |
| s".withFieldComputedPartial(_.$anotherToName, ...)" | |
| case TransformerOverride.Renamed(sourcePath, _) => | |
| s".withFieldRenamed($sourcePath, _.$anotherToName})" | |
| } |
It always returns _.fieldName even if the field is actually nested, and it never shows example for scoped overrides defined (e.g. withFieldComputedFrom(_.from)(_.to, ...)).
It could be improved, with tests, printing the right values from the journal etc.
Metadata
Metadata
Assignees
Labels
bugErroneous behavior in existing featuresErroneous behavior in existing featureslow hanging fruitTask that should be easy to implement - perfect for people that want to start contributing.Task that should be easy to implement - perfect for people that want to start contributing.