Skip to content

AdminApi Incorrect Arg Flag #1948

@james-newell-forge

Description

@james-newell-forge

This function doesn't seem correct, it looks like the field was moved to: redpanda.admin-api.authentication.basic.password

// RegisterFlags for sensitive Admin API configurations.
func (c *RedpandaAdminAPI) RegisterFlags(flags *flag.FlagSet) {
	flags.BoolVar(&c.Enabled, "redpanda.admin-api.password", c.Enabled, "Basic Auth password to authenticate against the Redpanda Admin API")
}

Also, it doesn't look like the redpanda configs are being included in the flag set?

// RegisterFlags for all (sub)configs
func (c *Config) RegisterFlags(f *flag.FlagSet) {
	f.StringVar(&c.ConfigFilepath, "config.filepath", "", "Path to the config file")
	f.BoolVar(&c.StrictConfigValidation, "config.strict-validation", true, "Strict validation rejects unknown variables in the provided YAML config")

	// Package flags for sensitive input like passwords
	c.Kafka.RegisterFlags(f)
	c.Serde.RegisterFlags(f)
	c.Console.RegisterFlags(f)
	c.KafkaConnect.RegisterFlags(f)
	c.SchemaRegistry.RegisterFlags(f)
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions