[Feature] Why doesn’t serveConfigV2 support file inputs

[Ethan-rookie]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

Could someone explain the design decision behind this limitation? thanks

Use case

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

[Future-Outlier]

1. what do you mean file inputs? can you give an example?

[Ethan-rookie]

spec: serveConfigV2: application.yaml
like this

[win5923]

RayService’s serveConfigV2 currently only accepts inline YAML strings, for the following reasons:

• In the CRD, serveConfigV2 is defined as a string, which means it is designed to contain the full YAML content directly.
  

  kuberay/ray-operator/apis/ray/v1/rayservice_types.go

  Lines 105 to 109 in aa8d830

  	// Important: Run "make" to regenerate code after modifying this file
  	// Defines the applications and deployments to deploy, should be a YAML multi-line scalar string.
  	// +optional
  	ServeConfigV2 string `json:"serveConfigV2,omitempty"`
  	RayClusterSpec RayClusterSpec `json:"rayClusterConfig"`

• The controller simply treats this string as YAML and unmarshals it.

kuberay/ray-operator/controllers/ray/rayservice_controller.go

Lines 1233 to 1240 in aa8d830

	func (r *RayServiceReconciler) updateServeDeployment(ctx context.Context, rayServiceInstance *rayv1.RayService, rayDashboardClient dashboardclient.RayDashboardClientInterface, clusterName string) error {
	logger := ctrl.LoggerFrom(ctx)
	logger.Info("updateServeDeployment", "V2 config", rayServiceInstance.Spec.ServeConfigV2)
	serveConfig := make(map[string]interface{})
	if err := yaml.Unmarshal([]byte(rayServiceInstance.Spec.ServeConfigV2), &serveConfig); err != nil {
	return err
	}

To support file-based inputs, maybe we can add a serveConfigV2From field to load the YAML from a referenced ConfigMap.

[Future-Outlier]

this is worth discussing, will put it in my topic to committers next time we have meeting, thank you @win5923