Make tag checks case-sensitive in a few formats that had it wrong #5921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags could very well be case insensitive, but only if we see that in
a spec or in the wild and to the best of my knowledge this doesn't
apply to any of these formats. Some of them even have their tags made
with our own *2john tools (which I then checked).
I also made sure nothing in our tree nor in the Test Suite has these
tags in a different case.
The only format that had me uncertain was sapH but some googling
seemed to confirm our tags for it are the correct (sometimes mixed)
case.
The LDAP tags I included here, {SSHA} and {SSHA512}, are not likely to
exist in lowercase anywhere while older ones such as {md5} or {sha}
theoretically could, but we only ever supported those in uppercase and
no-one ever complained.
solardiz
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags could very well be case insensitive, but only if we see that in a spec or in the wild and to the best of my knowledge this doesn't apply to any of these formats. Some of them even have their tags made with our own *2john tools (which I then checked).
I also made sure nothing in our tree nor in the Test Suite has these tags in a different case.
The only format that had me uncertain was sapH but some googling seemed to confirm our tags for it are the correct (sometimes mixed) case.
The LDAP tags I included here, {SSHA} and {SSHA512}, are not likely to exist in lowercase anywhere while older ones such as {md5} or {sha} theoretically could, but we only ever supported those in uppercase and no-one ever complained.