Skip to content

Conversation

@zhuwenxing
Copy link
Contributor

/kind improvement

Add comprehensive test cases for Milvus geometry data type support:
- Collection creation with geometry fields
- WKT data insertion (POINT, LINESTRING, POLYGON, MULTIPOINT, etc.)
- Geometry index building (RTREE, AUTOINDEX)
- Spatial query/search with multiple operators (ST_INTERSECTS, ST_CONTAINS, ST_WITHIN, ST_EQUALS, ST_TOUCHES, ST_OVERLAPS, ST_CROSSES)
- Tests cover sealed/growing data states, with/without geo index, nullable fields
- Upsert, delete operations with geometry data
- Default value support for geometry fields

Also add geometry utility functions for WKT generation and ground truth computation using shapely.

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/test sig/testing labels Dec 8, 2025
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 8, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhuwenxing
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/test labels Dec 8, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2025

@zhuwenxing cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.29%. Comparing base (3daff1a) to head (a9b9e77).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/validate_util.go 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #46174       +/-   ##
===========================================
- Coverage   82.76%   41.29%   -41.48%     
===========================================
  Files         526     1231      +705     
  Lines       82771   195114   +112343     
===========================================
+ Hits        68507    80569    +12062     
- Misses      14264   114208    +99944     
- Partials        0      337      +337     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 82.76% <ø> (ø)
Go 9.55% <0.00%> (∅)
Files with missing lines Coverage Δ
internal/proxy/validate_util.go 0.00% <0.00%> (ø)

... and 704 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor kind/test sig/testing size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants