Skip to content

Commit 93147c5

Browse files
Copilotasim
andcommitted
docs: refine comments based on code review feedback
- Clarify that Server ordering before Name is mandatory - Remove confusing comment about Client ordering being for consistency Co-authored-by: asim <17530+asim@users.noreply.github.com>
1 parent 05cc1e9 commit 93147c5

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

internal/website/docs/guides/grpc-compatibility.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ import (
156156

157157
func main() {
158158
// Create service with gRPC client
159-
// Note: Client should be set before Name for consistency
160159
service := micro.NewService(
161160
micro.Client(grpcClient.NewClient()),
162161
micro.Name("helloworld.client"),

internal/website/docs/transport.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ import (
2929
grpcClient "go-micro.dev/v5/client/grpc"
3030
)
3131

32-
// Note: Server and Client options should be specified before Name
32+
// Important: Server must be specified before Name
3333
service := micro.NewService(
3434
micro.Server(grpcServer.NewServer()),
3535
micro.Client(grpcClient.NewClient()),
36-
micro.Name("myservice"), // Name must come after Server
36+
micro.Name("myservice"),
3737
)
3838
```
3939

0 commit comments

Comments
 (0)