Skip to content

Conversation

@swrichards
Copy link
Collaborator

@swrichards swrichards commented Dec 3, 2025

Summary

First PR of a two-parter: this PR mainly ensures all API fields that have a counterpart in our ZGW models are in fact synced (especially during updates), and also that we give more comprehensive feedback regarding the sync outcome (including dropped entities, e.g. due to filters or errors).

Issue References

Checklist

  • CHANGELOG.rst updated

@swrichards swrichards force-pushed the us-3579-better-zgw-import branch 5 times, most recently from 91c46e7 to ba7db1e Compare December 3, 2025 11:48
@swrichards swrichards changed the title [WIP] improved zgw importing [#3579] Store not just successful syncs, but also failures and filters with reasons Dec 3, 2025
@swrichards swrichards force-pushed the us-3579-better-zgw-import branch 2 times, most recently from 4fb510a to 2078614 Compare December 3, 2025 11:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 98.81279% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.81%. Comparing base (9ac56d8) to head (7f68b01).

Files with missing lines Patch % Lines
src/open_inwoner/openzaak/zgw_imports.py 97.41% 8 Missing ⚠️
...rc/open_inwoner/openzaak/tests/test_zgw_imports.py 99.31% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2049      +/-   ##
===========================================
+ Coverage    92.65%   92.81%   +0.16%     
===========================================
  Files         1222     1221       -1     
  Lines        46832    47550     +718     
===========================================
+ Hits         43392    44135     +743     
+ Misses        3440     3415      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@swrichards swrichards force-pushed the us-3579-better-zgw-import branch 6 times, most recently from 3ec2702 to 5320bd7 Compare December 8, 2025 14:01
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! I think it's almost good to go, just a few small remarks.

@pi-sigma
Copy link
Contributor

pi-sigma commented Dec 8, 2025

@swrichards The failing test passes locally for me, maybe a fluke?

@swrichards
Copy link
Collaborator Author

@swrichards The failing test passes locally for me, maybe a fluke?

I'll take a look, some kind of hidden dependency on run order I think.

@swrichards swrichards force-pushed the us-3579-better-zgw-import branch 2 times, most recently from 61748da to 074ae81 Compare December 9, 2025 08:57
@swrichards swrichards force-pushed the us-3579-better-zgw-import branch from 074ae81 to 7f68b01 Compare December 9, 2025 09:00
@swrichards swrichards marked this pull request as ready for review December 9, 2025 09:04
@swrichards swrichards requested a review from pi-sigma December 9, 2025 09:04
@swrichards swrichards merged commit 561e87c into develop Dec 9, 2025
20 checks passed
@swrichards swrichards deleted the us-3579-better-zgw-import branch December 9, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants