-
Notifications
You must be signed in to change notification settings - Fork 6
[#3579] Store not just successful syncs, but also failures and filters with reasons #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91c46e7 to
ba7db1e
Compare
4fb510a to
2078614
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2049 +/- ##
===========================================
+ Coverage 92.65% 92.81% +0.16%
===========================================
Files 1222 1221 -1
Lines 46832 47550 +718
===========================================
+ Hits 43392 44135 +743
+ Misses 3440 3415 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/open_inwoner/openzaak/management/commands/zgw_import_data.py
Outdated
Show resolved
Hide resolved
3ec2702 to
5320bd7
Compare
pi-sigma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! I think it's almost good to go, just a few small remarks.
|
@swrichards The failing test passes locally for me, maybe a fluke? |
I'll take a look, some kind of hidden dependency on run order I think. |
61748da to
074ae81
Compare
074ae81 to
7f68b01
Compare
Summary
First PR of a two-parter: this PR mainly ensures all API fields that have a counterpart in our ZGW models are in fact synced (especially during updates), and also that we give more comprehensive feedback regarding the sync outcome (including dropped entities, e.g. due to filters or errors).
Issue References
Checklist