-
Notifications
You must be signed in to change notification settings - Fork 351
Open
Labels
kind/featureNew featureNew featuretriage/acceptedThe issue was reviewed and is complete enough to start working on itThe issue was reviewed and is complete enough to start working on it
Description
Description
It's often times useful to filter by status of dataplanes.
This currently doesn't work well because the filter doesn't act on insights.
kuma/pkg/api-server/resource_endpoints.go
Line 333 in db0fffb
| list, err = r.MergeInOverview(list, insights) |
We do filter well on insights:
kuma/pkg/api-server/resource_endpoints.go
Line 329 in db0fffb
| if err := r.resManager.List(request.Request.Context(), insights, store.ListByMesh(meshName), store.ListByNameContains(nameContains), store.ListByFilterFunc(filter)); err != nil { |
But we merge with the assumption that the resource list is the source of truth:
kuma/pkg/api-server/resource_endpoints.go
Line 353 in db0fffb
| items := r.descriptor.NewOverviewList() |
So there's a few ways to go about:
- Don't include resources when they don't have insights.
Metadata
Metadata
Assignees
Labels
kind/featureNew featureNew featuretriage/acceptedThe issue was reviewed and is complete enough to start working on itThe issue was reviewed and is complete enough to start working on it