Gather ansible_os_family in reset

[bbaassssiiee]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR gathers just the ansible_os_family that is required by the next task. This allows running the playbook without gather_facts: true, which increases the speed of exection.

Which issue(s) this PR fixes:

Fixes #12593

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bbaassssiiee
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @bbaassssiiee. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yankay]

/ok-to-test

[VannTen]

From what I can tell the reset playbook import internal_facts, which already gather some facts. Would'nt it make more sense to gather it here ? 🤔

[bbaassssiiee]

It is rathered in internal_facts.yml, but in issue 12593 @broboa said: "The reset role fails when trying to restart active network services.". Apparently not using the reset.yml playbook, but the collection's role. We could fix it in the role like this to support that.

[VannTen]

Hum the linked issue appear to invoke the role from remove-node.yml which also include internal facts, it seems.

[VannTen]

(and we should probably add a reset node test to one of the rhel9-like CI job to ensure this does not regress)