fix(execution): skip the render cache in flowable for properties used… #13525
+38
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
fix/flowable-render-cache
branch
from
ee84310 to
49b04fb
Compare
Contributor
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:13525 server local🧪 Java Unit Tests
|
Contributor
Tests report quick summary:success ✅ > tests: 3634, success: 3622, skipped: 12, failed: 0 unfold for details
Flaky tests report quick summary:success ✅ > tests: 31, success: 29, skipped: 2, failed: 0 unfold for details
|
… to compute next tasks As when the flowable is itself in a flowable that process tasks concurrently like the ForEach when using a concurrency limit, it can be done multiple time with different values. This can only occurs if the expression is using `taskRun.value`. Fixes kestra-io/kestra-ee#6055
loicmathieu
force-pushed
the
fix/flowable-render-cache
branch
from
49b04fb to
be62089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to compute next tasks
As when the flowable is itself in a flowable that process tasks concurrently like the ForEach when using a concurrency limit, it can be done multiple time with different values.
This can only occurs if the expression is using
taskRun.value.Fixes https://github.com/kestra-io/kestra-ee/issues/6055