Pause no longer shows up when it's not supported; now shows both pause and stop by default #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and stop by default
mjustian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was using this while writing an integration for a home audio controller. The controller supports internet radio, which does not support a pause button, leading to errors when the default pause button was clicked. Internet radio does, however, support a stop button. Furthermore, I would like to be able to change the source of the audio from internet radio to something else, such as Spotify, which does support pause, without needing to modify the mini media player's configuration.
This change makes both play/pause and play/stop enabled by default, as opposed to only play/pause being enabled. Furthermore, this change will hide pause and stop if those commands are not supported by the source device.