Skip to content

Feature/owntone group support #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanGiese wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Feature/owntone group support #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93277b4
added support for owntone
Mar 29, 2023
a4658db
added owntone to readme
Mar 29, 2023
6b878da
Merge branch 'master' into feature/owntone-group-support
Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ See [Speaker group management](#speaker-group-management) for example usage.
- linkplay<sup>[2](#speaker_foot2)</sup>
- media_player<sup>[3](#speaker_foot3)</sup>
- heos
- owntone<sup>[1](#speaker_foot1)</sup>

| Name | Type | Default | Description |
|------|------|---------|-------------|
Expand Down
3 changes: 2 additions & 1 deletion src/components/groupList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import './button';
import { HomeAssistant } from '../types';
import MediaPlayerObject from '../model';
import { MiniMediaPlayerSpeakerGroupEntry } from '../config/types';
import { PLATFORM} from './../const';
import { GroupChangeEvent } from './groupItem';

@customElement('mmp-group-list')
Expand Down Expand Up @@ -80,7 +81,7 @@ class MiniMediaPlayerGroupList extends LitElement {
@change=${this.handleGroupChange}
.item=${item}
.hass=${this.hass}
.checked=${itemId === entityId || this.group.includes(itemId)}
.checked=${(this.player.config.speaker_group.platform === PLATFORM.OWNTONE && this.hass.states[itemId].state !== "off") || itemId === entityId || this.group.includes(itemId)}
Copy link
Owner

@kalkih kalkih May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to not have platform specific logic spread throughout components, let's handle that in the Media Player model class.
Also how does the owntone checked logic work?
Should all owntone entities that are not "off" be considered as grouped? that doesn't seem right to me?

.disabled=${itemId === entityId || !this.isMaster}
.master=${itemId === this.master}
/>`;
Expand Down
1 change: 1 addition & 0 deletions src/const.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ const PLATFORM = {
SOUNDTOUCH: 'soundtouch',
MEDIAPLAYER: 'media_player',
HEOS: 'heos',
OWNTONE: 'owntone'
};

const CONTRAST_RATIO = 4.5;
Expand Down
16 changes: 16 additions & 0 deletions src/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,14 @@ export default class MediaPlayerObject {
},
PLATFORM.MEDIAPLAYER,
);
case PLATFORM.OWNTONE:
return this.callService(
e,
'turn_on',
{
entity_id: entity
}
);
default:
return this.callService(e, 'join', options, platform);
}
Expand Down Expand Up @@ -453,6 +461,14 @@ export default class MediaPlayerObject {
},
PLATFORM.MEDIAPLAYER,
);
case PLATFORM.OWNTONE:
return this.callService(
e,
'turn_off',
{
entity_id: entity
}
);
default:
return this.callService(e, 'unjoin', options, platform);
}
Expand Down